Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading usage of prop-types to new package #971

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Upgrading usage of prop-types to new package #971

merged 2 commits into from
Apr 18, 2017

Conversation

luisrudge
Copy link
Contributor

fix #970

@luisrudge luisrudge added this to the v10-Next milestone Apr 14, 2017
@luisrudge luisrudge force-pushed the feature/upgrade-prop-types branch from 527561f to be12b40 Compare April 14, 2017 18:03
hzalaz
hzalaz reviewed Apr 17, 2017
View reviewed changes
Copy link
Member

@hzalaz hzalaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this backwards compatible?

@luisrudge
Copy link
Contributor Author

Yes! https://github.com/reactjs/prop-types#compatibility
React 0.14.9 and React 15.3.0 and higher

@luisrudge luisrudge force-pushed the feature/upgrade-prop-types branch from be12b40 to 4df329d Compare April 18, 2017 14:29
@luisrudge luisrudge merged commit dfad802 into master Apr 18, 2017
@luisrudge luisrudge deleted the feature/upgrade-prop-types branch April 18, 2017 14:39
@gene1wood gene1wood mentioned this pull request Aug 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzalaz hzalaz hzalaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.15.0
Development

Successfully merging this pull request may close these issues.

Proptypes in the main react package is deprecated
2 participants
@luisrudge @hzalaz